Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default CMAKE options #55

Merged
merged 1 commit into from
Feb 20, 2018
Merged

Change default CMAKE options #55

merged 1 commit into from
Feb 20, 2018

Conversation

wsmoses
Copy link
Owner

@wsmoses wsmoses commented Feb 20, 2018

Build shared library, disable OCAML

@wsmoses
Change default CMAKE options
8fdb4b8 
Build shared library, disable OCAML
prigoyal
prigoyal approved these changes Feb 20, 2018
View reviewed changes
Copy link

@prigoyal prigoyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, once CI is green, go ahead and merge. These have been tested already on the TC side :)

yay

@wsmoses wsmoses merged commit ec3ad2b into master Feb 20, 2018
@wsmoses wsmoses deleted the wsmoses-patch-1 branch February 20, 2018 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prigoyal prigoyal prigoyal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wsmoses @prigoyal