Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix debug info linking issue #58

Merged
merged 1 commit into from
Feb 26, 2018
Merged

Fix debug info linking issue #58

merged 1 commit into from
Feb 26, 2018

Conversation

wsmoses
Copy link
Owner

@wsmoses wsmoses commented Feb 26, 2018

Module dump isn't linked into libTapir, so this removes such statements and leaves the relevant asserts.

Copy link

@prigoyal prigoyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine to me!

@neboat
Copy link
Collaborator

neboat commented Feb 26, 2018

These changes look fine to me. I'd like a test for this issue, but that can wait for a future PR.

@wsmoses wsmoses merged commit 195a877 into master Feb 26, 2018
@wsmoses wsmoses deleted the dlink branch February 26, 2018 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants