-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C and OCaml bindings for Tapir #66
Conversation
I'm excited to see these additions. The changes looks good to me. Do you have a test case handy for verifying that these changes work? |
I don't have anything small that tests them. DEF will use these changes as soon as they're ready. I can commit and push those changes, though I was planning on doing it in the opposite order. Is that what we need? |
…ge to the set of packages.
Okay! I've created a tapir-transition branch to DEF: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though yeah at one point some unit tests would be nice.
Sorry, apparently CI wasn't configured properly for PR's from external forks, if you don't mind repushing to trigger a build (and then you'll be able to merge once the build passes). |
I'll add the OCaml stuff into the unit tests for it. That'll cover the C bindings, too, since OCaml uses them. When I push that change, will that trigger the build? |
Like a boss! |
When you wish upon a star, makes no difference who you are. Because in space, no one can hear you scream.