Qthreads backend #71
Merged
Qthreads backend #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsmoses
reviewed
Jul 12, 2018
| @@ -94,8 +94,7 @@ class LoopSpawningHints { | |||
| case LoopSpawningHints::ST_DAC: | |||
| return "Use divide-and-conquer"; | |||
| case LoopSpawningHints::ST_END: | |||
| default: | |||
| return "Unknown"; | |||
| return "ST_END"; | |||
There was a problem hiding this comment.
(perhaps keep to return unknown?)
wsmoses
requested changes
Jul 12, 2018
| @@ -94,8 +94,7 @@ class LoopSpawningHints { | |||
| case LoopSpawningHints::ST_DAC: | |||
| return "Use divide-and-conquer"; | |||
| case LoopSpawningHints::ST_END: | |||
| default: | |||
| return "Unknown"; | |||
| return "ST_END"; | |||
There was a problem hiding this comment.
(perhaps keep to return unknown?)
| ; inserts the correct Cilk ABI calls. | ||
| ; | ||
| ; RUN: opt < %s -tapir2target -tapir-target=qthreads -debug-abi-calls -S | FileCheck %s | ||
|
|
stelleg
force-pushed
the
qthreads
branch
3 times, most recently
from
bc5b33e
to
6a2e7e0
Compare
|
@wsmoses Comments should be addressed |
wsmoses
previously approved these changes
Jul 12, 2018
wsmoses
approved these changes
Jul 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Qthreads backend. Will submit the necessary tapir-clang PR shortly.