Skip to content
This repository has been archived by the owner on Oct 5, 2021. It is now read-only.

Fixing IDENTITY-3181 #444

Merged
merged 1 commit into from
Jun 17, 2015
Merged

Fixing IDENTITY-3181 #444

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...so2/carbon/identity/application/authenticator/samlsso/manager/DefaultSAML2SSOManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,7 +414,7 @@ private LogoutRequest buildLogoutRequest(String user, String sessionIndexStr, St
logoutReq.setIssuer(issuer);

NameID nameId = new NameIDBuilder().buildObject();
nameId.setFormat("urn:oasis:names:tc:SAML:2.0:nameid-format:entity");
nameId.setFormat("urn:oasis:names:tc:SAML:2.0:nameid-format:unspecified");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it good to define this string as a string constant ?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, these string literals must be contained as a constant.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already fixed in #784

nameId.setValue(user);
logoutReq.setNameID(nameId);

Expand Down