Update the module with ballerina 0.990.0 #60

kalaiyarasiganeshalingam · 2018-12-07T17:40:36Z

Purpose

Update the module with ballerina 0.990.0.

In the github connector, only 41 testcase are successfully run and other testcases are failure because the data map.

Goals

Describe the solutions that this feature/fix will introduce to resolve the problems described above

Approach

Describe how you are implementing the solutions. Include an animated GIF or screenshot if the change affects the UI (email documentation@wso2.com to review all UI text). Include a link to a Markdown file or Google doc if the feature write-up is too long to paste here.

User stories

Summary of user stories addressed by this change>

Release note

Brief description of the new feature or bug fix as it will appear in the release notes

Documentation

Link(s) to product documentation that addresses the changes of this PR. If no doc impact, enter “N/A” plus brief explanation of why there’s no doc impact

Training

Link to the PR for changes to the training content in https://github4.com/wso2/WSO2-Training, if applicable

Certification

Type “Sent” when you have provided new/updated certification questions, plus four answers for each question (correct answer highlighted in bold), based on this change. Certification questions/answers should be sent to certification@wso2.com and NOT pasted in this PR. If there is no impact on certification exams, type “N/A” and explain why.

Marketing

Link to drafts of marketing content that will describe and promote this feature, including product page changes, technical articles, blog posts, videos, etc., if applicable

Automation github4.tests

Unit github4.tests

Code coverage information
Integration github4.tests

Details about the test cases and coverage

Security checks

Followed secure coding standards in http://wso2.com/technical-reports/wso2-secure-engineering-guidelines? yes/no
Ran FindSecurityBugs plugin and verified report? yes/no
Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets? yes/no

Samples

Provide high-level details about the samples related to this feature

Related PRs

List any other related PRs

Migrations (if applicable)

Describe migration steps and platforms on which migration has been tested

Test environment

List all JDK versions, operating systems, databases, and browser/versions on which this feature/fix was tested

Learning

Describe the research phase and any blog posts, patterns, libraries, or add-ons you used to solve the problem.

Made the changes

ldclakmal · 2018-12-08T04:40:32Z

README.md

+        repository = rep;
+    } else {
+        io:println(err);
+


Please remove new line here.

ldclakmal · 2018-12-08T04:43:01Z

github4/github_constants.bal


 // Public constants
 # Pull request state open, closed and merged
-@final public string PULL_REQUEST_STATE_ALL = "[\"OPEN\",\"CLOSED\",\"MERGED\"]";
+final string PULL_REQUEST_STATE_ALL = "[\"OPEN\",\"CLOSED\",\"MERGED\"]";


Removing public access modifier here block the usage of these variables for end users. Please correct it all the places where applicable.

Suggested change

final string PULL_REQUEST_STATE_ALL = "[\"OPEN\",\"CLOSED\",\"MERGED\"]";

public final string PULL_REQUEST_STATE_ALL = "[\"OPEN\",\"CLOSED\",\"MERGED\"]";

ldclakmal · 2018-12-08T04:45:24Z

github4/github_constants.bal

 # Closed state
-@final public string STATE_CLOSED = "[\"CLOSED\"]";
+final string STATE_CLOSED = "[\"CLOSED\"]";


Suggested change

final string STATE_CLOSED = "[\"CLOSED\"]";

public final string STATE_CLOSED = "[\"CLOSED\"]";

ldclakmal · 2018-12-08T04:45:32Z

github4/github_constants.bal

 # Merged state
-@final public string STATE_MERGED = "[\"MERGED\"]";
+final string STATE_MERGED = "[\"MERGED\"]";


Suggested change

final string STATE_MERGED = "[\"MERGED\"]";

public final string STATE_MERGED = "[\"MERGED\"]";

ldclakmal · 2018-12-08T04:45:41Z

github4/github_constants.bal

 # Open state
-@final public string STATE_OPEN = "[\"OPEN\"]";
+final string STATE_OPEN = "[\"OPEN\"]";


Suggested change

final string STATE_OPEN = "[\"OPEN\"]";

public final string STATE_OPEN = "[\"OPEN\"]";

ldclakmal · 2018-12-08T04:45:50Z

github4/github_constants.bal

 # State open and closed
-@final public string STATE_ALL = "[\"OPEN\",\"CLOSED\"]";
+final string STATE_ALL = "[\"OPEN\",\"CLOSED\"]";


Suggested change

final string STATE_ALL = "[\"OPEN\",\"CLOSED\"]";

public final string STATE_ALL = "[\"OPEN\",\"CLOSED\"]";

ldclakmal · 2018-12-08T04:48:02Z

github4/github_data_mappings.bal

+        target_repository.owner = {};
+    } else {
+        var result = RepositoryOwner.convert(source_json.owner);
+        if(result is RepositoryOwner) {


Suggested change

if(result is RepositoryOwner) {

if (result is RepositoryOwner) {

ldclakmal · 2018-12-08T04:48:10Z

github4/github_data_mappings.bal

+        target_repository.primaryLanguage = {};
+    } else {
+        var result = Language.convert(source_json.primaryLanguage);
+        if(result is Language) {


Suggested change

if(result is Language) {

if (result is Language) {

ldclakmal · 2018-12-08T04:48:50Z

github4/github_endpoint.bal

+# + githubGraphQlClient - HTTP client endpoint
+public type Client client object {
+
+    public http:Client githubRestClient;


Suggested change

public http:Client githubRestClient;

http:Client githubRestClient;

ldclakmal · 2018-12-08T04:49:00Z

github4/github_endpoint.bal

+public type Client client object {
+
+    public http:Client githubRestClient;
+    public http:Client githubGraphQlClient;


Suggested change

public http:Client githubGraphQlClient;

http:Client githubGraphQlClient;

ldclakmal · 2018-12-08T04:49:58Z

github4/github_endpoint.bal

+    # + labelList - List of labels for the issue
+    # + assigneeList - Users to be assigned to the issue
+    # + return - Created issue object or Connector error
+    remote function createIssue(string repositoryOwner, string repositoryName, string issueTitle, string issueContent,


All of these remote functions should have public access modifier. Otherwise, this prevents the enduser to call these. Right?

ldclakmal · 2018-12-08T04:51:09Z

github4/github_endpoint.bal

+                        }
+                    }
+                } else {
+                error err = error(GITHUB_ERROR_CODE


Please format the code here.

ldclakmal · 2018-12-08T04:51:42Z

github4/github_endpoint.bal

+remote function Client.getColumnListNextPage(ColumnList columnList) returns ColumnList|error {
+
+    if (columnList.hasNextPage()) {
+    var jsonQuery = stringToJson(columnList.columnListQuery);


Please format the code in everywhere of this remote function.

ldclakmal · 2018-12-08T04:51:56Z

github4/github_endpoint.bal

+    if (repository is Repository) {
+        repositoryOwner = repository.owner.login;
+        repositoryName = repository.name;
+    } else if (repository is (string, string)){


Suggested change

} else if (repository is (string, string)){

} else if (repository is (string, string)) {

ldclakmal · 2018-12-08T04:52:22Z

github4/github_endpoint.bal

+    //Check for empty payloads and errors
+    json|error validatedResponse = getValidatedResponse(response, GIT_ISSUES);
+
+    if(validatedResponse is json) {


Suggested change

if(validatedResponse is json) {

if (validatedResponse is json) {

ldclakmal · 2018-12-08T04:53:03Z

github4/github_endpoint.bal

+        if (result is Project) {
+            return result;
+        } else {
+        error err = error(GITHUB_ERROR_CODE


Please format the code here.

ldclakmal · 2018-12-08T04:53:20Z

github4/github_endpoint.bal

+returns RepositoryList|error {
+
+    string organizationName = "";
+    if(organization is Organization) {


Suggested change

if(organization is Organization) {

if (organization is Organization) {

ldclakmal · 2018-12-08T04:56:29Z

github4/github_utils.bal

-
-        error err => {
+    if (response is http:Response) {
+        if(response.getJsonPayload() is error) {


Suggested change

if(response.getJsonPayload() is error) {

if (response.getJsonPayload() is error) {

Fix Made the changes in the testcases

Kalaiyarasi and others added 6 commits December 5, 2018 16:39

Update the connector with latest syntax

091ccc4

Update the module with ballerina 0.990.0

ed3a36f

Made the changes in the types file

0c50675

Made the changes

Made the changes in the doc

8b64ee0

Merge branch 'master' into master

679adea

Minor changes

3144a81

ldclakmal reviewed Dec 8, 2018

View reviewed changes

README.md Outdated

repository = rep;

} else {

io:println(err);

Copy link

Member

ldclakmal Dec 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove new line here.

ldclakmal reviewed Dec 8, 2018

View reviewed changes

github4/github_endpoint.bal Outdated

}

}

} else {

error err = error(GITHUB_ERROR_CODE

Copy link

Member

ldclakmal Dec 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please format the code here.

ldclakmal reviewed Dec 8, 2018

View reviewed changes

Fix the suggested changes

c691a9d

Fix Made the changes in the testcases

ldclakmal approved these changes Dec 8, 2018

View reviewed changes

VijithaEkanayake-zz approved these changes Dec 8, 2018

View reviewed changes

VijithaEkanayake-zz merged commit 3588e11 into ballerina-platform:master Dec 8, 2018

ldclakmal mentioned this pull request Dec 8, 2018

Fix connector for Ballerina 0.990.0 #61

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update the module with ballerina 0.990.0 #60

Update the module with ballerina 0.990.0 #60

kalaiyarasiganeshalingam commented Dec 7, 2018 •

edited

ldclakmal Dec 8, 2018

ldclakmal Dec 8, 2018 •

edited

ldclakmal Dec 8, 2018

ldclakmal Dec 8, 2018

ldclakmal Dec 8, 2018

ldclakmal Dec 8, 2018

ldclakmal Dec 8, 2018

ldclakmal Dec 8, 2018

ldclakmal Dec 8, 2018

ldclakmal Dec 8, 2018

ldclakmal Dec 8, 2018 •

edited

ldclakmal Dec 8, 2018

ldclakmal Dec 8, 2018

ldclakmal Dec 8, 2018

ldclakmal Dec 8, 2018

ldclakmal Dec 8, 2018

ldclakmal Dec 8, 2018

ldclakmal Dec 8, 2018

	final string PULL_REQUEST_STATE_ALL = "[\"OPEN\",\"CLOSED\",\"MERGED\"]";
	public final string PULL_REQUEST_STATE_ALL = "[\"OPEN\",\"CLOSED\",\"MERGED\"]";

	final string STATE_CLOSED = "[\"CLOSED\"]";
	public final string STATE_CLOSED = "[\"CLOSED\"]";

	final string STATE_MERGED = "[\"MERGED\"]";
	public final string STATE_MERGED = "[\"MERGED\"]";

	final string STATE_OPEN = "[\"OPEN\"]";
	public final string STATE_OPEN = "[\"OPEN\"]";

	final string STATE_ALL = "[\"OPEN\",\"CLOSED\"]";
	public final string STATE_ALL = "[\"OPEN\",\"CLOSED\"]";

	if(result is RepositoryOwner) {
	if (result is RepositoryOwner) {

	public http:Client githubRestClient;
	http:Client githubRestClient;

	public http:Client githubGraphQlClient;
	http:Client githubGraphQlClient;

	} else if (repository is (string, string)){
	} else if (repository is (string, string)) {

	if(validatedResponse is json) {
	if (validatedResponse is json) {

	if(organization is Organization) {
	if (organization is Organization) {

	if(response.getJsonPayload() is error) {
	if (response.getJsonPayload() is error) {

Update the module with ballerina 0.990.0 #60

Update the module with ballerina 0.990.0 #60

Conversation

kalaiyarasiganeshalingam commented Dec 7, 2018 • edited

Purpose

Goals

Approach

User stories

Release note

Documentation

Training

Certification

Marketing

Automation github4.tests

Security checks

Samples

Related PRs

Migrations (if applicable)

Test environment

Learning

Choose a reason for hiding this comment

ldclakmal Dec 8, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ldclakmal Dec 8, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kalaiyarasiganeshalingam commented Dec 7, 2018 •

edited

ldclakmal Dec 8, 2018 •

edited

ldclakmal Dec 8, 2018 •

edited