adding api manager keycloak keymanager code #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
bhathiya
reviewed
Apr 5, 2020
| } | ||
| // for(JSONValue value : (JSONArray)responseMap.get(KeycloakConstants.CLIENT_REDIRECT_URIS)){ | ||
| // uris.add(value.asString()); | ||
| // } |
There was a problem hiding this comment.
Yes. I will remove it.
bhathiya
reviewed
Apr 5, 2020
| if((Boolean) responseMap.get(KeycloakConstants.GRANT_TYPE_CLIENT_CREDENTIALS_KEYCLOAK)){ | ||
| grantTypeList.add(KeycloakConstants.GRANT_TYPE_CLIENT_CREDENTIALS); | ||
| } | ||
| if((Boolean) responseMap.get(KeycloakConstants.GRANT_TYPE_PASSWORD_KEYCLOAK)){ |
There was a problem hiding this comment.
Yes. Will reformat.
bhathiya
reviewed
Apr 5, 2020
| } catch (IOException e) { | ||
| handleException("Error while reading response body", e); | ||
| } finally { | ||
| closeResources(null, httpClient); |
There was a problem hiding this comment.
In fact, the closable resources defined in try are final. I cannot initialize my buffered reader there since I need to reassign the entity value from HTTP response to it. To keep the code consistent, I will keep using the finally block.
There was a problem hiding this comment.
I have used multiple try blocks and accommodated this recommendation.
bhathiya
approved these changes
Apr 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Adding initial code base for api manager keycloak keymanager component.
Goals
Provision Keycloak as a third party key manager for WSO2 APIM 2.6
Approach
Keycloak Client is written extending the AbstractKeyManager class.
User stories
Adopting a third party key manager, Keycloak for API Manager 2.6.0
Release note
Third party keymanager implementation for API Manager and Keycloak.
Documentation
Will be added in the future.
Training
N/A
Certification
N/A. Does not lie on the major flaws in APIM since it is custom implementation.
Marketing
N/A
Automation tests
N/A
Security checks
Samples
Related PRs
N/A
Migrations (if applicable)
N/A
Test environment
JDK 8
Learning
Keycloak official documentation
https://www.keycloak.org/docs-api/5.0/rest-api/index.html#_clients_resource