Modified the code in order to support with IS 5.3.0 #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malakasilva
suggested changes
Jul 28, 2017
| @@ -39,7 +39,7 @@ | |||
| </init-param> | |||
| <init-param> | |||
| <param-name>serverName</param-name> | |||
| <param-value>https://localhost:8080</param-value> | |||
| <param-value>https://localhost:8443</param-value> | |||
There was a problem hiding this comment.
Please explain the reasons for changing this?
There was a problem hiding this comment.
If we use 8080, https won't work on Mac.
| import org.wso2.carbon.registry.core.utils.UUIDGenerator; | ||
|
|
||
| import java.io.UnsupportedEncodingException; | ||
| import java.io.*; |
| serviceUrl = decoder | ||
| .decode(casMessageContext.getRequest().getQueryString().replace("service=", ""), "UTF-8"); | ||
| } catch (UnsupportedEncodingException e) { | ||
| throw new FrameworkException("Unable to decode the service URL", e); |
There was a problem hiding this comment.
Can we verify with IS team if this is the best way to do this?
| import org.wso2.carbon.identity.sso.cas.exception.CAS2ClientException; | ||
| import org.wso2.carbon.identity.sso.cas.util.CASResourceReader; | ||
| import org.wso2.carbon.identity.sso.cas.util.CASSSOUtil; | ||
|
|
||
| import javax.servlet.http.HttpServletRequest; | ||
| import javax.servlet.http.HttpServletResponse; | ||
| import java.io.UnsupportedEncodingException; | ||
| import java.io.*; |
| } else { | ||
| builder = new CASServiceValidateRequest.CASServiceValidateRequestBuilder(request, response); | ||
| ((CASServiceValidateRequest.CASServiceValidateRequestBuilder) builder).setLocale(request); | ||
| } | ||
| } else { | ||
| throw CAS2ClientException.error("Invalid request message or invalid service url"); | ||
| } | ||
|
|
||
| Enumeration attributeNames = request.getAttributeNames(); |
There was a problem hiding this comment.
With this are we removing needed elements as well?
There was a problem hiding this comment.
We remove non serialised attributes for now. Once they fix the issue in framework level, we need to remove this part from the authenticator.
kesavany
approved these changes
Jul 31, 2017
malakasilva
approved these changes
Jul 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.