Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboard app level pvtkeyjwt reuse config #2499

Conversation

mpmadhavig
Copy link
Contributor

@mpmadhavig mpmadhavig commented Jun 17, 2024

Purpose

This PR contains changes relevant to on-boarding of App level config to Allow Reuse of Private Key JWT. The following component has been affected by the PR.

  • components/org.wso2.carbon.identity.api.server.dcr

    • Updated the DTOs related to DCR endpoint.
  • components/org.wso2.carbon.identity.oauth.common

    • Constant re-initializing to avoid the cyclic dependency.
  • components/org.wso2.carbon.identity.oauth.dcr

    • Updated the beans related DCR endpoint.
  • components/org.wso2.carbon.identity.oauth

    • Updated DTOs and beans related OAuth Apps.
    • Implemented logic to read org level config using the ConfigurationManager.

Please Note:

  • The config will be saved as a SP OIDC property.
  • For the already created applications, as the config is not added, the old org level config will be taken.
    • When retrieving the application via a GET request, if the config is unavailable, org level config will be set.
  • For the newly created applications, the user configured value will be saved.
    • The org level config will be totally irrelevant for the new application.

Related PRs:

wso2/product-is#20546

@CLAassistant
Copy link

CLAassistant commented Jun 17, 2024

CLA assistant check
All committers have signed the CLA.

@mpmadhavig mpmadhavig force-pushed the onboard-app-level-pvtkeyjwt-reuse-config branch 8 times, most recently from 909bbae to 3846061 Compare June 26, 2024 03:21
@mpmadhavig mpmadhavig force-pushed the onboard-app-level-pvtkeyjwt-reuse-config branch 2 times, most recently from c939914 to 64fe82a Compare June 27, 2024 13:01
shashimalcse
shashimalcse previously approved these changes Jul 1, 2024
@mpmadhavig mpmadhavig force-pushed the onboard-app-level-pvtkeyjwt-reuse-config branch from 8e0ef0f to 90778ba Compare July 1, 2024 15:22
shashimalcse
shashimalcse previously approved these changes Jul 1, 2024
shashimalcse
shashimalcse previously approved these changes Jul 1, 2024
@mpmadhavig mpmadhavig merged commit c251411 into wso2-extensions:master Jul 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants