Fix progressive enrolment of passkey for JIT-Provisioned federated user #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, Username less authentication
Username based authentication
Basic AuthenticationPass Key as first factor
Passkey as second factor
Email OTPPass Key as first factor
Passkey as second factor
Google FederationPass Key as first factor
Passkey as second factor
Based on the test results, I am approving the PR |
Thumimku
approved these changes
Jan 26, 2024
| @@ -1278,4 +1278,12 @@ public boolean isFidoKeyRegistered (String username) throws AuthenticationFailed | |||
| throw new AuthenticationFailedException(e.getMessage()); | |||
| } | |||
| } | |||
|
|
|||
| public boolean isFidoKeyRegistered (AuthenticatedUser authenticatedUser) throws AuthenticationFailedException { | |||
| try { | |||
There was a problem hiding this comment.
can add a line after method signature
| } | ||
| // Have to set idpName to the context since | ||
| // the FederatedAuthenticatorUtil.getLocalUsernameAssociatedWithFederatedUser is expecting it. | ||
| context.setProperty("idpName", authenticatedUser.getFederatedIdPName()); |
There was a problem hiding this comment.
can have a constant for idpName
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves wso2/product-is#18774