Integrating coverage plugin and adding unit tests - Sprint 1 #3802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The check on the 70% code coverage has been commented out so that the build wont break until the coverage goal is met. |
harsha89
requested changes
Mar 13, 2017
| import org.wso2.carbon.apimgt.core.dao.ApplicationDAO; | ||
| import org.wso2.carbon.apimgt.core.dao.PolicyDAO; | ||
| import org.wso2.carbon.apimgt.core.dao.TagDAO; | ||
| import org.wso2.carbon.apimgt.core.dao.*; |
| import static org.mockito.Mockito.verify; | ||
| import static org.mockito.Mockito.when; | ||
|
|
||
| import static org.mockito.Mockito.*; |
| @@ -132,13 +138,116 @@ public void testAddApplication() throws APIManagementException { | |||
| APIStore apiStore = new APIStoreImpl(USER_NAME, null, applicationDAO, null, policyDAO, null, null); | |||
| Application application = new Application(APP_NAME, USER_NAME); | |||
| application.setTier(TIER); | |||
| application.setPermissionString("[{\"groupId\": \"testGroup\",\"permission\":[\"READ\",\"UPDATE\",\"DELETE\",\"SUBSCRIPTION\"]}]"); | |||
There was a problem hiding this comment.
line length too long? which is 120 by defualt
| * Tests to catch exceptions in methods | ||
| */ | ||
|
|
||
| //Cannot be caught because the subscriptionID is randomly generated inside the method |
There was a problem hiding this comment.
can we remove the commented out code?
| apiStore.getAllTags(); | ||
| } | ||
|
|
||
| @Test(description = "Exception when getting all policies of a specific policy level", expectedExceptions = APIMgtDAOException.class) |
| application.setTier(TIER); | ||
| when(applicationDAO.isApplicationNameExists(APP_NAME)).thenReturn(false); | ||
| when(policyDAO.getPolicy(APIMgtConstants.ThrottlePolicyConstants.APPLICATION_LEVEL, TIER)).thenReturn(policy); | ||
| doThrow(new APIMgtDAOException("Error occurred while creating the application - " + application.getName())).when(applicationDAO).addApplication(application); |
There was a problem hiding this comment.
line length. Please fix in other places as well
| import static org.mockito.Mockito.times; | ||
| import static org.mockito.Mockito.verify; | ||
| import static org.mockito.Mockito.when; | ||
| import static org.mockito.Mockito.*; |
| * Test cases for exceptions | ||
| */ | ||
|
|
||
| @Test(description = "Exception when retrieving an application by uuid", expectedExceptions = APIMgtDAOException.class) |
|
Sure, will do the changes. Thanks for the review. |
harsha89
approved these changes
Mar 14, 2017
This was referenced Mar 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.