Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for root level lists under namespace #76

Merged
merged 1 commit into from
Aug 2, 2019

Conversation

niveathika
Copy link
Member

@niveathika niveathika commented Aug 2, 2019

Purpose

Add support for root level lists under namespace as follows,

testTransports:
  - testTransport:
      name: abc
      port: 9090
      secure: true
      desc: This transport will use 8000 as its port
      password: ${sec:conn.auth.password}
  - testTransport:
      name: pqrs
      port: ${env:pqr.http.port}
      secure: ${sys:pqr.secure}
      desc: This transport will use ${env:pqr.http.port} as its port. Secure - ${sys:pqr.secure}
  - testTransport:
      name: xyz
      port: ${env:xyz.http.port,9000}
      secure: ${sys:xyz.secure,true}
      desc: This transport will use ${env:xyz.http.port,8888} as its port

Goals

Add support for root level lists under namespace which can be retrived through configProvider.getConfigurationObject("") and processed as needed
As per discussions under https://groups.google.com/forum/?hl=en#!topic/siddhi-dev/j3W4mA8jjQ8

Approach

When dumping we if the TAG is not Map, them we dump it as a sequence and return.

User stories

N/A

Release note

N/A

Documentation

N/A

Training

N/A

Certification

N/A

Marketing

N/A

Automation tests

  • Unit tests - Attached to the PR
  • Integration tests - N/A

Security checks

Samples

N/A

Related PRs

N/A

Migrations (if applicable)

N/A

Test environment

JDK 1.8.0_191

Learning

N/A

@mohanvive mohanvive merged commit 760fdd6 into wso2:master Aug 2, 2019
mohanvive added a commit that referenced this pull request Aug 2, 2019
Fix test case introduced in #76
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants