Skip current session from being terminated at password update #3124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DinikaSen
requested review from
Abilashini,
DMHP,
Kanapriya,
piraveena,
pulasthi7 and
senthalan
as code owners
senthalan
approved these changes
Oct 9, 2020
|
PR builder passed : https://jenkins-support-all.wso2.com/jenkins/job/DEV_PR_BUILDER/872/ |
pulasthi7
reviewed
Oct 12, 2020
|
|
||
| <!-- Configuration for preserving the current session and token when updating the password. --> | ||
| <PasswordUpdate> | ||
| <PreserveLoggedInSession>{{password_update.preserve_logged_in_session}}</PreserveLoggedInSession> |
There was a problem hiding this comment.
[password_update] should not be a top level configuration. Can you check the existing configurations and come up with a proper existing top level config
There was a problem hiding this comment.
Re-defined under [identity_mgt] configurations
pulasthi7
approved these changes
Oct 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves session preserving part of - wso2/product-is#9461
With this improvement, it is possible to skip the current session/token from being terminated/revoked at password update, which stops the user from being logged out from the current session. This feature can be enabled the following configuration in deployment.toml