IDENTITY-5365: Improving claim cache to act as invalidation cache #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darshanasbg
force-pushed
the
IDENTITY-5365
branch
from
edf5ed8
to
cf9f10b
Compare
darshanasbg
changed the title
darshanasbg
force-pushed
the
IDENTITY-5365
branch
from
cf9f10b
to
33e8f71
Compare
darshanasbg
changed the title
darshanasbg
commented
Nov 28, 2016
| } | ||
|
|
||
| public void addExternalClaim(ExternalClaim externalClaim, int tenantId) throws ClaimMetadataException { | ||
|
|
||
| externalClaimDAO.addExternalClaim(externalClaim, tenantId); | ||
| clearExternalClaimCache(externalClaim.getClaimDialectURI()); | ||
| invalidate(externalClaim.getClaimDialectURI(), tenantId); | ||
| } | ||
|
|
||
| public void updateLocalClaim(ExternalClaim externalClaim, int tenantId) throws ClaimMetadataException { |
There was a problem hiding this comment.
need to be renamed as updateExternalClaim
darshanasbg
force-pushed
the
IDENTITY-5365
branch
from
33e8f71
to
b2430de
Compare
darshanasbg
force-pushed
the
IDENTITY-5365
branch
from
b2430de
to
387b969
Compare
pulasthi7
approved these changes
Nov 29, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.