This repository has been archived by the owner on Oct 5, 2021. It is now read-only.
Fixing IDENTITY-3181 #444
Merged
Fixing IDENTITY-3181 #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -414,7 +414,7 @@ private LogoutRequest buildLogoutRequest(String user, String sessionIndexStr, St | |||
| logoutReq.setIssuer(issuer); | |||
|
|
|||
| NameID nameId = new NameIDBuilder().buildObject(); | |||
| nameId.setFormat("urn:oasis:names:tc:SAML:2.0:nameid-format:entity"); | |||
| nameId.setFormat("urn:oasis:names:tc:SAML:2.0:nameid-format:unspecified"); | |||
There was a problem hiding this comment.
Isn't it good to define this string as a string constant ?
There was a problem hiding this comment.
Yes, these string literals must be contained as a constant.
JKAUSHALYA
pushed a commit
to JKAUSHALYA/carbon-identity
that referenced
this pull request
Nov 17, 2015
CARBON-14508: org.wso2.carbon.registry.core.exceptions.ResourceNotFou…
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.