Create source jars. Generate Java Docs. Run JaCoCo report #22
Conversation
…ranch of wso2/code-quality-tools repository
|
Updated checkstyle configuration to use released files in wso2/code-quality-tools repository |
| </plugin> | ||
| <plugin> | ||
| <groupId>org.jacoco</groupId> | ||
| <artifactId>jacoco-maven-plugin</artifactId> |
There was a problem hiding this comment.
should we add this by default?
There was a problem hiding this comment.
Yes, because we need to get coverage for the code we write. The code coverage report will be generated when the tests are executed. Therefore it's very important to know the coverage and to understand whether the tests have covered critical code sections.
| </plugin> | ||
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-source-plugin</artifactId> |
There was a problem hiding this comment.
@chrishantha Is it necessary to generate javadocs and sources everytime? This adds to the build time of our repos. Please note that maven-deploy-plugin always generate javadocs and sources during releases. That's where these plugins are most important. @jsdjayanga, please review.
There was a problem hiding this comment.
From my experience, only Java Docs generation takes more time. It doesn't take much time to create the source jar. Having Java Docs plugin is important as we can focus on Java Doc issues before the release time. Having Java Docs plugin enabled by default, developers can focus on Java Docs while development and without having to focus on Java Docs only at the release time.
Also fixed a typo, formatted the file and updated plugin versions. Specified minimum Maven version required as 3.0.5 as mentioned by the "mvn versions:display-plugin-updates" command