Fix the SecureVault bundle activator exception handling issue

[ksdperera]

Purpose

Resolves issue in SecureVault bundle activator exception handling. The existing implementation throws the errors while initializing the component bubble up to OSGi framework, but the problem is carbon logging uses pax logging as logging framework and it's not supported for Eclipse Equinox logging framework. Hence this OSGi bundle exception not captured by the logging framework.

Goals

Fix the SecureVault bundle activator exception handling issue

Approach

Catch the Throwable and logging the exception with compatible logging framework and bubble-up the exception to OSGi framework.

User stories

N/A

Release note

N/A

Documentation

N/A

Training

N/A

Certification

N/A

Marketing

N/A

Automation tests

• Unit tests
• Integration tests

Security checks

• Followed secure coding standards in http://wso2.com/technical-reports/wso2-secure-engineering-guidelines? yes
• Ran FindSecurityBugs plugin and verified report? yes
• Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets? yes

Samples

N/A

Related PRs

N/A

Migrations (if applicable)

N/A

Test environment

N/A

Learning

N/A

[this]

Appending throwable.getMessage() doesn't add any value. Exception message will be automatically printed by the logger when printing the throwable. So let's remove that.

logger.error("Cannot initialize secure vault.", throwable);

[this]

Above applies here too.

throw new SecureVaultException("Cannot initialize secure vault.", throwable);

[this]

Also, do we really need to catch Throwable here. Any reason why Exception (or any other exception) is not sufficient.

[this]

Why we shouldn't catch Throwable: https://stackoverflow.com/a/6083271/1577286

[ksdperera]

Fixes apply: ff567a8

[ksdperera]

Reg: Throwable, yes it may be best practise to catch the Exception only. But here the problem is there is issue in carbon logging framework where it coudn't catch the eclipse equinox frameowrk logs and becouse of the it may hidden the Throwable causes without logging to carbon log file.