Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make having a page mandatory in a web app to be deployed #53

Merged
merged 2 commits into from
Dec 6, 2017
Merged

Make having a page mandatory in a web app to be deployed #53

merged 2 commits into from
Dec 6, 2017

Conversation

this
Copy link
Member

@this this commented Dec 6, 2017

Purpose

Fixes #52

Goals

If a web app does not have the pages directory or any pages, then do not deploy that web app.

Approach

  • If pages directory is missing, throw a file operation exception.
  • If there are no pages, then throw an app creation exception.

Automation tests

  • Unit tests
    Improved AppCreatorTest
    Code coverage: 45%
  • Integration tests
    N/A

Security checks

@TanyaM TanyaM merged commit ed434ec into wso2:master Dec 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TanyaM TanyaM TanyaM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@this @TanyaM