Always use the PRIMARY userstore to add local claims in Asgardeo #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure that the PRIMARY store is beign used to add the local claims in Asgardeo.
DMHP
reviewed
Apr 11, 2023
| @@ -969,6 +969,13 @@ private void validateAttributeMappings(List<AttributeMappingDTO> attributeMappin | |||
| throw handleClaimManagementClientError(ERROR_CODE_EMPTY_MAPPED_ATTRIBUTES_IN_LOCAL_CLAIM, | |||
| BAD_REQUEST, attributeMappingDTO.getUserstore()); | |||
| } | |||
| if (IdentityUtil.getHostName().contains("asgardeo.io") || IdentityUtil.getHostName().contains("asg.io")) { | |||
| if (!primaryUserstoreDomainName.equalsIgnoreCase(attributeMappingDTO.getUserstore())) { | |||
| throw handleClaimManagementClientError(ERROR_CODE_INVALID_USERSTORE.getCode(), "You can only use" | |||
There was a problem hiding this comment.
Why do we need to throw this exception only if the host names are asgardeo.io and asg.io? We can't use any other userstore name even if we use a different domain right? (As the Asgardeo userstore is named as primary)
There was a problem hiding this comment.
Yes, I needed to check whether this is on-prem or Asgardeo and if it's Asgardeo not allowed to use any other userstores. That's why I used this logic
DMHP
reviewed
Apr 11, 2023
...2/carbon/identity/rest/api/server/claim/management/v1/core/ServerClaimManagementService.java
Outdated
Show resolved
Hide resolved
Use `ClaimManagement.BindToPrimaryUserStore` to check whether we should use only the primary userstore to add local claims
kayathiri4
reviewed
Apr 25, 2023
...2/carbon/identity/rest/api/server/claim/management/v1/core/ServerClaimManagementService.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose