call-back-api #446
Open
call-back-api #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
dewniMW
reviewed
Apr 28, 2023
| @@ -0,0 +1,33 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <!-- | |||
| ~ Copyright (c) 2022, WSO2 LLC. (http://www.wso2.com). All Rights Reserved. | |||
There was a problem hiding this comment.
update with the correct year. check all files
dewniMW
reviewed
Apr 28, 2023
| <groupId>org.wso2.carbon.identity.server.api</groupId> | ||
| <artifactId>org.wso2.carbon.identity.api.server.workflow.management</artifactId> | ||
| <relativePath>../pom.xml</relativePath> | ||
| <version>1.2.43-SNAPSHOT</version> |
There was a problem hiding this comment.
when merging the PR, need to make sure the correct version is included here
dewniMW
reviewed
Apr 28, 2023
| import org.wso2.carbon.identity.workflow.mgt.WorkFlowExecutorManager; | ||
|
|
||
| /** | ||
| * Service holder class for user organization management services. |
dewniMW
reviewed
Apr 28, 2023
Comment on lines
29
to
30
| * @param requestId workflow request id. | ||
| * @param workflowApprovalPatchRequest workflow request status. |
dewniMW
reviewed
Apr 28, 2023
| * @param workflowApprovalPatchRequest workflow request status. | ||
| * @throws WorkflowException throw exception while approving workflow request | ||
| */ | ||
| public void approveWorkflowRequest(String requestId, WorkflowApprovalPatchRequest workflowApprovalPatchRequest) throws WorkflowException { |
There was a problem hiding this comment.
check if this exceeds the maximum character length (120) limit
dewniMW
reviewed
Apr 28, 2023
| public void approveWorkflowRequest(String requestId, WorkflowApprovalPatchRequest workflowApprovalPatchRequest) throws WorkflowException { | ||
|
|
||
| getWorkFlowExecutorManager().handleCallback(requestId, workflowApprovalPatchRequest.getStatus(), null); | ||
|
|
dewniMW
reviewed
Apr 28, 2023
| * Custom exception for user organization management endpoint. | ||
| */ | ||
| public class WorkflowManagementEndpointException extends WebApplicationException { | ||
| private String errorCode; |
There was a problem hiding this comment.
add a new line after the class declaration
dewniMW
reviewed
Apr 28, 2023
Comment on lines
35
to
37
| public WorkflowManagementEndpointException(String errorCode) { | ||
|
|
||
| } |
There was a problem hiding this comment.
what's the purpose of this?
dewniMW
reviewed
Apr 28, 2023
| package org.wso2.carbon.identity.workflow.mgt.api.v1.impl; | ||
|
|
||
| import org.springframework.beans.factory.annotation.Autowired; | ||
| import org.wso2.carbon.identity.workflow.mgt.api.v1.*; |
There was a problem hiding this comment.
avoid star imports. please note this is not applicable for files in gen folder
dewniMW
reviewed
Apr 28, 2023
| import java.util.List; | ||
| import javax.ws.rs.core.Response; | ||
|
|
||
| public class WorkflowApiServiceImpl implements WorkflowApiService { |
dewniMW
reviewed
Apr 28, 2023
| import org.springframework.beans.factory.annotation.Autowired; | ||
| import org.wso2.carbon.identity.workflow.mgt.api.v1.*; | ||
| import org.wso2.carbon.identity.workflow.mgt.api.v1.core.WorkflowManagementService; | ||
| import org.wso2.carbon.identity.workflow.mgt.api.v1.exceptions.WorkflowManagementEndpointException; |
There was a problem hiding this comment.
seems like this import is not used within the class
dewniMW
reviewed
Apr 28, 2023
| public Response workflowWorkflowIdPatch(String workflowId, WorkflowApprovalPatchRequest workflowApprovalPatchRequest) { | ||
|
|
||
| try { | ||
| workflowManagementService.approveWorkflowRequest(workflowId,workflowApprovalPatchRequest); |
dewniMW
reviewed
Apr 28, 2023
| // /** | ||
| // * An error code. | ||
| // **/ | ||
| // public Error code(String code) { |
There was a problem hiding this comment.
remove this class if not used
dewniMW
reviewed
Apr 28, 2023
| // | ||
| //import javax.ws.rs.core.Response; | ||
| // | ||
| //public class WorkflowManagementEndpointUtil { |
There was a problem hiding this comment.
remove this class if not needed
dewniMW
reviewed
Apr 28, 2023
| responses: | ||
| '200': | ||
| description: Successful Response | ||
|
|
dewniMW
reviewed
Apr 28, 2023
| properties: | ||
| code: | ||
| type: string | ||
| example: UOM-00000 |
There was a problem hiding this comment.
is this the correct error code prefix?
dewniMW
reviewed
Apr 28, 2023
| type: string | ||
| example: 'APPROVED' | ||
|
|
||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Goals
Approach
User stories
Release note
Documentation
Training
Certification
Marketing
Automation tests
Security checks
Samples
Related PRs
Migrations (if applicable)
Test environment
Learning