Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboard app level pvtkeyjwt reuse config #622

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mpmadhavig
Copy link
Contributor

@mpmadhavig mpmadhavig commented Jun 17, 2024

Purpose

This PR contains changes relevant to onboarding of App level config to Allow Reuse of Private Key JWT. The changes will be reflected at the below endpoints:

  1. /{applicationId}/inbound-protocols/oidc - GET, PUT, DELETE
  2. /meta/inbound-protocols/oidc
  • The config will be saved as a SP OIDC property.
  • For the already created applications, as the config is not added, the old org level config will be taken.
    • When retrieving the application via a GET request, if the config is unavailable, org level config will be set.
  • For the newly created applications, the user configured value will be saved.
    • The org level config will be totally irrelevant for the new application.

Related PRs:

wso2/product-is#20546

@mpmadhavig mpmadhavig force-pushed the onboard-app-level-pvtkeyjwt-reuse-config branch 2 times, most recently from c1045e4 to 93c9ab1 Compare June 28, 2024 05:20
shashimalcse
shashimalcse previously approved these changes Jul 1, 2024
@mpmadhavig mpmadhavig force-pushed the onboard-app-level-pvtkeyjwt-reuse-config branch from 93c9ab1 to cdc19b7 Compare July 8, 2024 08:29
shashimalcse
shashimalcse previously approved these changes Jul 10, 2024
Copy link
Contributor

@Thumimku Thumimku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants