Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing file stream print() with IOUtils.copy #130

Merged
merged 2 commits into from
Aug 7, 2015

Conversation

rasika
Copy link
Contributor

@rasika rasika commented Jul 16, 2015

Fixing performance issue in file stream print() method

manuranga added a commit that referenced this pull request Aug 7, 2015
Replacing file stream print() with IOUtils.copy
@manuranga manuranga merged commit 3d9414a into wso2:master Aug 7, 2015
}
} else {
try {
out.write(HostObjectUtil.serializeObject(args[0]).getBytes());
} catch (IOException e) {
log.debug(e.getMessage(), e);
if (log.isDebugEnabled()) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be an error log, IMO.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already fixed in #4ecf8fe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants