Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NullPointerException on calling User Info Endpoint #1953

Closed
vrustia-owens opened this issue Jan 2, 2018 · 10 comments
Closed

NullPointerException on calling User Info Endpoint #1953

vrustia-owens opened this issue Jan 2, 2018 · 10 comments

Comments

@vrustia-owens
Copy link

Upon successful login via open id connect, the service provider is successful in retrieving the claims from the user info endpoint. After updating the user profile or updating the Service Provider Configuration in WSO2 IS, I encountered this exception below. Upon quick inspection, the code segment and the exception implies that the cache entry is nullified because of the said actions on the UI, and since the code that triggered this doesn't handle null cache entry, therefore would cause NullPointerException on this code

Code origin of error:
https://github.com/wso2-extensions/identity-inbound-auth-oauth/blob/d89eda3083585eeed5763b2b4abf65a440c06a65/components/org.wso2.carbon.identity.oauth/src/main/java/org/wso2/carbon/identity/openidconnect/AbstractUserInfoResponseBuilder.java#L298

Exception encountered:

Caused by: java.lang.NullPointerException
	at org.wso2.carbon.identity.openidconnect.AbstractUserInfoResponseBuilder.getRequestObject(AbstractUserInfoResponseBuilder.java:298)
	at org.wso2.carbon.identity.openidconnect.AbstractUserInfoResponseBuilder.getResponseString(AbstractUserInfoResponseBuilder.java:82)
	at org.wso2.carbon.identity.oauth.endpoint.user.OpenIDConnectUserEndpoint.getUserClaims(OpenIDConnectUserEndpoint.java:80)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:497)
	at org.apache.cxf.service.invoker.AbstractInvoker.performInvocation(AbstractInvoker.java:188)
	at org.apache.cxf.service.invoker.AbstractInvoker.invoke(AbstractInvoker.java:104)
@vrustia-owens
Copy link
Author

Any planned milestone for this one?
We are to use WSO2 Identity Server as OpenID Connect Provider on production hopefully early this year, probably around March. I hope we are able to get the fix for this one.

Thank you very much your attention.

@isharak
Copy link
Member

isharak commented Jan 4, 2018

Hi,
Thanks for pointing out. We will fix this soon and update the issue.

-Ishara

IndunilRathnayake added a commit to wso2-extensions/identity-inbound-auth-oauth that referenced this issue Jan 4, 2018
@DMHP DMHP self-assigned this Jan 4, 2018
@erwinant
Copy link

erwinant commented Jan 5, 2018

Hi everyone, I'm wso2noob, can you explain, how to implement this on my source code?

@vrustia-owens
Copy link
Author

Hi @erwin123
I can't understand the context you are coming from. Also if you want to understand how to use WSO2 IS, you can refer to the docs, here

@vrustia-owens
Copy link
Author

Nice job, guys.
By the way is there any way to know which milestone would this bug fix be included and when?
Thanks!

@erwinant
Copy link

erwinant commented Jan 5, 2018

I have been gotten this error, it means, i ve done to running wso2. My question is, this issue has been solved right? And how i can implement this fixed version on my wso2?

@bhathiya
Copy link

bhathiya commented Jan 6, 2018

@erwin123 Clone tag 5.5.168 of https://github.com/wso2-extensions/identity-inbound-auth-oauth and apply the fix in https://github.com/wso2-extensions/identity-inbound-auth-oauth/pull/752/files. Then build the jar and replace the same jar in <IS_HOME>/repository/components/plugins/.

@bhathiya
Copy link

bhathiya commented Jan 6, 2018

@DMHP IMO it's necessary to have integration tests to maintain the stability of such critical functionalities.

@vrustia-owens
Copy link
Author

vrustia-owens commented Jan 10, 2018

any updates on this? =)

@isharak isharak added this to the 5.4.0-Update4 milestone Jan 10, 2018
@ashensw
Copy link
Member

ashensw commented Jan 10, 2018

Hi @vrustia-owens

We have planned to release this fix with IS 5.4.0-Update4 which is scheduled to be released on 11th of Jan 2018.

Thanks,
Ashen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants