Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: ALPN negotiation does not happen at listener level #3348

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

VirajSalaka
Copy link
Contributor

Purpose

Issues

Fixes #

Automation tests

  • Unit tests added: Yes/No
  • Integration tests added: Yes/No

Tested environments

Not Tested


Maintainers: Check before merge

  • Assigned 'Type' label
  • Assigned the project
  • Validated respective github issues
  • Assigned milestone to the github issue(s)

@VirajSalaka VirajSalaka changed the title Bug fix: ALPN negotiation does not happen at listner level Bug fix: ALPN negotiation does not happen at listener level May 3, 2023
@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (9cad359) 27.49% compared to head (9528e90) 27.50%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #3348   +/-   ##
=========================================
  Coverage     27.49%   27.50%           
- Complexity     3368     3369    +1     
=========================================
  Files           483      483           
  Lines         51826    51827    +1     
  Branches       6337     6337           
=========================================
+ Hits          14248    14253    +5     
+ Misses        36184    36178    -6     
- Partials       1394     1396    +2     
Impacted Files Coverage Δ
adapter/internal/oasparser/envoyconf/listener.go 64.93% <100.00%> (+0.10%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants