mqtt axis2 transport #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <dependency> | ||
| <groupId>org.apache.axis2</groupId> | ||
| <artifactId>axis2-kernel</artifactId> | ||
| <version>1.6.1-wso2v10</version> |
There was a problem hiding this comment.
Move the version to the parent pom of this repository. Also the version is old. Switch to the latest axis2 version.
| @@ -0,0 +1,113 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <!-- | |||
| ~ Licensed to the Apache Software Foundation (ASF) under one | |||
There was a problem hiding this comment.
Add the year in the license header.
| * @param qos the maximum quality of service to receive messages at for this subscription | ||
| * @throws MqttException | ||
| */ | ||
| public void subscribe(String topicName, int qos) throws Throwable { |
There was a problem hiding this comment.
Same comment I've made earlier on throwing "Throwable"s applies here as well.
Nirothipan
pushed a commit
to Nirothipan/wso2-axis2-transports-1
that referenced
this pull request
May 6, 2020
ESBJAVA-4289 [JMS Dual Channel] Avoid JMS selectors when Reply Destination is not defined
Nirothipan
pushed a commit
to Nirothipan/wso2-axis2-transports-1
that referenced
this pull request
May 6, 2020
Nirothipan
pushed a commit
to Nirothipan/wso2-axis2-transports-1
that referenced
this pull request
May 6, 2020
Revert "Merge pull request wso2#38 from hastef88/dualchannel"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.