Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

True Shape #70

Open
jhelsel11 opened this issue May 12, 2020 · 3 comments
Open

True Shape #70

jhelsel11 opened this issue May 12, 2020 · 3 comments
Assignees

Comments

@jhelsel11
Copy link
Contributor

The link shape file returned by lasso does not have the shape geometries, just straight line distances.

@kulshresthaa, thanks for looking at this. Will you give a quick update sometime this afternoon or tomorrow to keep @RachelWikenMC in the loop?

@i-am-sijia
Copy link
Member

@kulshresthaa I made changes in Lasso to take geometries from shapes_df instead of links_df, by simple column concat. Just need to confirm the consistency between links and shapes from network wrangler, when there are link addition and deletion involved.

@jhelsel11
Copy link
Contributor Author

Thank you for solving this. I will reach out to @RachelWikenMC to provide her with new true shapes and discuss how she can produce the link.shp files.

@AshishKuls
Copy link
Member

AshishKuls commented May 13, 2020

@jhelsel11 not completely done yet. Can you keep the issue open?

We need to make sure that on the wrangler side, links (links_df) and shapes (shapes_df) are consistent with each other (after applying the project card). They currently are not!
+@e-lo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants