Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 3.0.0.beta2 #46

Closed
yelled3 opened this issue Mar 23, 2014 · 4 comments
Closed

Add support for 3.0.0.beta2 #46

yelled3 opened this issue Mar 23, 2014 · 4 comments

Comments

@yelled3
Copy link
Contributor

yelled3 commented Mar 23, 2014

hopefully, this will make the transition to rspec 3 smoother :-)

@philostler philostler added this to the Unscheduled milestone Mar 25, 2014
@philostler
Copy link
Collaborator

I've not done testing against 3.0.0.beta2 yet

Have you(?) and are there are current failures popping up?

@yelled3
Copy link
Contributor Author

yelled3 commented Mar 26, 2014

rspec spec 
[rspec-sidekiq] WARNING! Sidekiq will *NOT* process jobs in this environment. See https://github.com/philostler/rspec-sidekiq/wiki/FAQ-&-Troubleshooting                        
  1) RSpec::Sidekiq::Matchers::HaveEnqueuedJob#matches? when condition matches when expected are matchers returns true                                                          
     Failure/Error: expect(matcher_subject.matches? worker).to be true

       expected true
            got #<FalseClass:0> => false
     # ./spec/rspec/sidekiq/matchers/have_enqueued_job_spec.rb:46:in `block (5 levels) in <top (required)>'

 86/86 |======================================================================== 100 =========================================================================>| Time: 00:00:00 

Finished in 0.19959 seconds
86 examples, 1 failure

Failed examples:

rspec ./spec/rspec/sidekiq/matchers/have_enqueued_job_spec.rb:45 # RSpec::Sidekiq::Matchers::HaveEnqueuedJob#matches? when condition matches when expected are matchers returns true

Deprecation Warnings:

--------------------------------------------------------------------------
RSpec::Sidekiq::Matchers::BeDelayed implements a legacy RSpec matcher
protocol. For the current protocol you should expose the failure messages
via the `failure_message` and `failure_message_when_negated` methods.
(Used from /Users/yelled/Development/rspec-sidekiq/spec/rspec/sidekiq/matchers/be_delayed_spec.rb:25:in `block (3 levels) in <top (required)>')
--------------------------------------------------------------------------

--------------------------------------------------------------------------
RSpec::Sidekiq::Matchers::BeProcessedIn implements a legacy RSpec matcher
protocol. For the current protocol you should expose the failure messages
via the `failure_message` and `failure_message_when_negated` methods.
(Used from /Users/yelled/Development/rspec-sidekiq/spec/rspec/sidekiq/matchers/be_processed_in_spec.rb:15:in `block (3 levels) in <top (required)>')
--------------------------------------------------------------------------

--------------------------------------------------------------------------
RSpec::Sidekiq::Matchers::BeRetryable implements a legacy RSpec matcher
protocol. For the current protocol you should expose the failure messages
via the `failure_message` and `failure_message_when_negated` methods.
(Used from /Users/yelled/Development/rspec-sidekiq/spec/rspec/sidekiq/matchers/be_retryable_spec.rb:18:in `block (3 levels) in <top (required)>')
--------------------------------------------------------------------------

--------------------------------------------------------------------------
RSpec::Sidekiq::Matchers::BeUnique implements a legacy RSpec matcher
protocol. For the current protocol you should expose the failure messages
via the `failure_message` and `failure_message_when_negated` methods.
(Used from /Users/yelled/Development/rspec-sidekiq/spec/rspec/sidekiq/matchers/be_unique_spec.rb:9:in `block (3 levels) in <top (required)>')
--------------------------------------------------------------------------

--------------------------------------------------------------------------
RSpec::Sidekiq::Matchers::HaveEnqueuedJob implements a legacy RSpec matcher
protocol. For the current protocol you should expose the failure messages
via the `failure_message` and `failure_message_when_negated` methods.
(Used from /Users/yelled/Development/rspec-sidekiq/spec/rspec/sidekiq/matchers/have_enqueued_job_spec.rb:14:in `block (3 levels) in <top (required)>')
--------------------------------------------------------------------------

The Fuubar formatter uses the deprecated formatter interface.
 Formatter added at: /Users/yelled/.rvm/gems/ruby-1.9.3-p362/gems/rspec-core-3.0.0.beta2/exe/rspec:4:in `<top (required)>'

Using `stub` from rspec-mocks' old `:should` syntax without explicitly enabling the syntax is deprecated. Use the new `:expect` syntax or explicitly enable `:should` instead. Called from /Users/yelled/Development/rspec-sidekiq/lib/rspec/sidekiq/batch.rb:37:in `block (2 levels) in <top (required)>'.


If you need more of the backtrace for any of these deprecations to
identify where to make the necessary changes, you can configure
`config.raise_errors_for_deprecations!`, and it will turn the
deprecation warnings into errors, giving you the full backtrace.

7 deprecation warnings total

Randomized with seed 19180

[Coveralls] Outside the Travis environment, not sending data.
Coverage report generated for RSpec to /Users/yelled/Development/rspec-sidekiq/spec_result. 182 / 187 LOC (97.33%) covered.

@yelled3
Copy link
Contributor Author

yelled3 commented Mar 26, 2014

@philostler opened a PR - I'll fix all the issues and warnings.

@philostler
Copy link
Collaborator

Superseded by #47

@philostler philostler modified the milestones: 2.0.0, Unscheduled Jun 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants