Add support for 3.0.0 #47
Conversation
yelled3
changed the title
yelled3
changed the title
|
@philostler take a look :-) |
| context "when expected is a delay" do | ||
| it "returns message" do | ||
| expect(delay_subject.negative_failure_message).to eq "expected Object.nil? to not be delayed" | ||
| expect(delay_subject.failure_message_when_negated).to eq "expected Object.nil? to not be delayed" |
There was a problem hiding this comment.
@philostler IMO, you should invoke failure_message_when_negated directly
I think it's much better to do:
https://github.com/rspec/rspec-expectations/blob/master/spec/rspec/matchers/built_in/compound_spec.rb#L48
|
+1 |
|
@zolzaya @philostler good to merge? |
|
Mmm.... This isn't backwards compatible with RSpec 2.x and without 3 out yet I'm not willing to merge is in with master. RSpec 3 support is of course required though, I'll sort out a new branch to maintain RSpec 3 support shortly |
|
@philostler, @yelled3 thank you guys :D |
|
RSpec 3 is now out. Anything new with this? I'm upgrading a project to RSpec 3 and it would be good to remove deprecation warnings from this gem. |
| Sidekiq::Batch.stub(:new) { RSpec::Sidekiq::NullBatch.new } | ||
| Sidekiq::Batch::Status.stub(:new) { RSpec::Sidekiq::NullStatus.new } | ||
| allow(Sidekiq::Batch).to receive(:new) { RSpec::Sidekiq::NullBatch.new } | ||
| allow(Sidekiq::Batch::Status).to receive(:new) { RSpec::Sidekiq::NullStatus.new } |
There was a problem hiding this comment.
maybe it's better to use?
https://www.relishapp.com/rspec/rspec-mocks/v/2-11/docs/stubbing-constants/stub-defined-constant
|
@aprescott i'll need to recheck :-) |
…ec3-beta Conflicts: lib/rspec/sidekiq/matchers/have_enqueued_job.rb rspec-sidekiq.gemspec
|
@dmasur I removed you're @aprescott other then that - I think we're good to go. |
|
looks great. thanks |
|
It looks like you're still using |
|
Just to say putting |
|
@aprescott CI is green again - thanks for the tip :-)
@zolzaya @philostler @dmasur good to merge? |
|
|
|
@dmasur I don't have merge permissions :-/ |
|
OK, thanks for your work on this everyone. I've been distracted with other projects over the last few months but I'm finally moving back to sorting out the pull request/issues etc on rspec-sidekiq. I'm actually migrating some of my projects over to RSpec 3 atm so I'm going to be grabbing this and start playing with it shortly before merging. There are a a few feature pull requests that have come in and I need to get a steer on whether those guys need RSpec 2 support with those features or not. I'm also weary about dropping RSpec 2 support completely as there are still a lot of people on 2.x that won't be upgrading right away |
|
@philostler FYI, make sure to checkout transpec |
|
@yelled3 Nice, cheers for that. That'll save some 🕦 |
|
I'm pegging this pull request to the 2.0.0 milestone as this is a breaking change for RSpec 2 users. Also means I can feed in features for the RSpec 2 guys before the upgrade |
|
Is there an estimated time this'll be available in a release? |
👍 |
|
This is now merged into the I'm seeing 4 tests failing which is probably to do with the pull requests for the 1.1.0 release clashing with this pull. There's also some implementation upgrading, linting and spec improvements I'm going to make before pushing out a full release. I'll however prioritise getting the tests passing and hang out a |
@philostler i'll take a look |
|
Can confirm one case of a project working off the |
|
What is a due date of release this? |
|
Now merged into |
|
Thanks for merging! |
|
long last - cheers :-) |
|
This is now released as a 2.0.0.beta gem build for people to test out |
Issue: #46