Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add implementation of status.total #39

Merged
merged 1 commit into from
Dec 30, 2013
Merged

Conversation

matthargett
Copy link

Ran into an issue where we couldn't test drive some functionality, and extended this "Null Object Pattern" to deal appropriately.

@coveralls
Copy link

Coverage Status

Coverage increased (+8.53%) when pulling 5de181a on PacerPRO:master into ef23ab6 on philostler:master.

philostler added a commit that referenced this pull request Dec 30, 2013
Add implementation of status.total
@philostler philostler merged commit 85f05ea into wspurgin:master Dec 30, 2013
philostler added a commit that referenced this pull request Dec 30, 2013
Copy link
Contributor

@lastobelus lastobelus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the total number of jobs in SIdekiq, but BatchStatus total should just be the total number of jobs in this batch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants