Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clash with rspec-rails #95

Merged
merged 4 commits into from
Jun 27, 2016
Merged

Conversation

pavel-jurasek
Copy link

@pavel-jurasek pavel-jurasek commented Jun 7, 2016

This PR fix clash with rspec-rails

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.8%) to 95.971% when pulling 214d5d5 on pavel-jurasek-bcgdv-com:develop into e9f2256 on philostler:develop.

@coveralls
Copy link

coveralls commented Jun 8, 2016

Coverage Status

Coverage decreased (-0.8%) to 96.0% when pulling c023ad7 on pavel-jurasek-bcgdv-com:develop into e9f2256 on philostler:develop.

@philostler
Copy link
Collaborator

Hi @pavel-jurasek-bcgdv-com , is this in addition to #84 or an improved version of?

@pavel-jurasek
Copy link
Author

@philostler improved version

@pavel-jurasek
Copy link
Author

  • Add ability to match symbols
  • Fix matcher with combination with ActiveJob

@philostler philostler added this to the v3.0.0 milestone Jun 27, 2016
@philostler philostler merged commit a2a4800 into wspurgin:develop Jun 27, 2016
@philostler
Copy link
Collaborator

Thanks @pavel-jurasek-bcgdv-com . Merged!

@bk-one
Copy link

bk-one commented Sep 27, 2016

Can we get a backport of that in rspec-sidekiq 2.x? Or is 3.0 coming in the foreseeable future? Happy to provide a patch

@bk-one
Copy link

bk-one commented Sep 27, 2016

#108

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants