Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Haptic Touch context menus #942

Merged
merged 1 commit into from Mar 9, 2020
Merged

Haptic Touch context menus #942

merged 1 commit into from Mar 9, 2020

Conversation

MichaelMKenny
Copy link
Contributor

Added Haptic Touch previewing with menu actions. Also added support for previewing wishlist items.

Closes #764

@worldlydev
Copy link
Contributor

Does this also add support for #566? Context menu support for the homepage

@wstyres wstyres self-requested a review March 9, 2020 23:04
wstyres
wstyres approved these changes Mar 9, 2020
View reviewed changes
Copy link
Member

@wstyres wstyres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@wstyres
Copy link
Member

wstyres commented Mar 9, 2020

@worldlydev It doesn't add support for #566, will have to take a look at that at a later date.

@wstyres wstyres merged commit 6e37fe1 into zbrateam:1.1 Mar 9, 2020
@wstyres wstyres mentioned this pull request Mar 9, 2020
Closed
MichaelMKenny added a commit to MichaelMKenny/Zebra that referenced this pull request Mar 10, 2020
@MichaelMKenny
Fixed missing weakSelf occurrences from PR zbrateam#942.
c79255b
@MichaelMKenny MichaelMKenny mentioned this pull request Mar 10, 2020
Merged
wstyres pushed a commit that referenced this pull request Mar 12, 2020
@MichaelMKenny
[Home] Homepage context menus and fixes (#943)
5399e41 
* Fixed missing weakSelf occurrences from PR #942.

* Set missing parent on preview depictionVCs.

This fixes downgrade alertVC not presenting.

* Added Haptic Touch context menu support for homepage.

Closes #566
@worldlydev worldlydev mentioned this pull request Jun 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wstyres wstyres wstyres approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MichaelMKenny @worldlydev @wstyres