docker-compose-prod.yml vs docker-compose.prod.yml

[SPH73]

I have some questions because deployment fails because there are no config vars picked up other than those set in heroku config vars manually
I bought v3.0 and v3.1 of the DFP books and there is a difference with regards to the volumes being left in on 3.1 but removed 3.0.
I realise no one else is having the same issue as no issue raised but I would like to understand better.

Next question: if using heroku.yml is it in place of docker-compose-prod.yml and therefore volumes left in the file isn't an issue?

What am I doing wrong or have I missed something?
In 3.0 ENVIRONMENT == 'production' but in 3.1 not inlcluded and ENVIRONMENT added to heroku manually doesn't pick up ENVIRONMENT in config.settings and django complains it is undefined as well, anyway.

Mainly my question is : How do the ENV vars in docker-compose-prod.yml get copied over or do I completely forget about the docker-compose files and add them myself i.e. Email settings, stripe keys etc?

Any comments would be appreciated because I urgently need to complete this step in the correct manner

[wsvincent]

Hi @SPH73,

I'm late in response but...

• heroku.yml is needed for Docker images within Heroku https://devcenter.heroku.com/articles/build-docker-images-heroku-yml. It is Heroku-specific. The docker-compose-prod.yml file works for all Docker containers.
• I understand your confusion around how the ENVs are copied over. You can either use the -f flag to force usage of the prod yml file or do what we did in the book which is use docker-compose-prod.yml to test production locally and then manually update the env vars within Heroku.

Thanks for your question.

[SPH73]

Hi William, Thank you for responding. I will make a note of this within my project README doc. I will need to update this project at some point and it will be good to have a reference then. Best regards, Sue

…

On 16 May 2022, at 16:32, William Vincent ***@***.***> wrote: Hi @SPH73 <https://github.com/SPH73>, I'm late in response but... heroku.yml is needed for Docker images within Heroku https://devcenter.heroku.com/articles/build-docker-images-heroku-yml <https://devcenter.heroku.com/articles/build-docker-images-heroku-yml>. It is Heroku-specific. The docker-compose-prod.yml file works for all Docker containers. I understand your confusion around how the ENVs are copied over. You can either use the -f flag <https://docs.docker.com/compose/production/> to force usage of the prod yml file or do what we did in the book which is use docker-compose-prod.yml to test production locally and then manually update the env vars within Heroku. Thanks for your question. — Reply to this email directly, view it on GitHub <#73 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALOTHF4CBN7E5O5PZEKG64TVKJTBLANCNFSM4VECUL4Q>. You are receiving this because you were mentioned.