Remove base64 encoding for text/plain mimetype #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also "text" and "json" entries are split so that the overlap doesn't bring to either of the two to be hidden. A plain text string is added to the tests and documentation is updated to make sure it is explicitly stated that plain text is NOT encoded any more.
- "var" is substituted by "const" - indentation is made consistent (tabs vs spaces) - doc typos fixes
|
@wswebcreation I think we should apply the same treatment to |
wswebcreation
approved these changes
May 22, 2022
There was a problem hiding this comment.
Wow @BaCaRoZzo
Thanks for all the fixes!
Regarding this
@wswebcreation I think we should apply the same treatment to text/html, i.e. remove the base64 encoding also there. Since I'm not sure what's the feeling about that I left that for the PR discussion. 😄
Yes, please, can you also fix it there?
|
@wswebcreation done as requested. Also dropped the library in a separate commit since it went unused. |
|
Thanks @BaCaRoZzo ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46
The actual fix is in 66de549, the rest are just improvements and minor fixes which, I hope, are welcome as well. 🙂
Regarding the fix itself, it simply removes the encoding for
text/plainbut also reworks a bit the template. Basicallystep.textandstep.jsonwere overlapping causing the two to end up in the samediv. I don't think that was wanted as we have two separateddivs forjsonandtext. Hence, I've made sure to correctly split them.orderCxlhas been added to the tests and it is indeed processed as expected now.