Skip to content
This repository has been archived by the owner on Dec 24, 2023. It is now read-only.

Update getAndroidStatusAddressToolBarHeight.ts for Android 9 #35

Merged
merged 1 commit into from
Oct 3, 2019
Merged

Update getAndroidStatusAddressToolBarHeight.ts for Android 9 #35

merged 1 commit into from
Oct 3, 2019

Conversation

mikesalvia
Copy link

@mikesalvia mikesalvia commented Oct 2, 2019 •
edited

For Android 9 there is only a major version in navigator.appVersion
Screen Shot 2019-10-02 at 2 32 06 PM

Match updated to work with Android 9
Screen Shot 2019-10-02 at 2 31 56 PM

@wswebcreation wswebcreation self-requested a review October 3, 2019 07:37
@wswebcreation wswebcreation self-assigned this Oct 3, 2019
wswebcreation
wswebcreation approved these changes Oct 3, 2019
View reviewed changes
Copy link
Owner

@wswebcreation wswebcreation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, I'll add a UT for it today and will release a new version

@wswebcreation wswebcreation merged commit 939ac16 into wswebcreation:master Oct 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wswebcreation wswebcreation wswebcreation approved these changes

Assignees

@wswebcreation wswebcreation

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mikesalvia @wswebcreation