馃摝 New Feature: Colors to black functionality #45
Conversation
|
@wswebcreation will look into the failure to see why this is happening and see about some unit tests |
There was a problem hiding this comment.
Hi @mikesalvia
Thanks for this PR.
Can you also provide some examples in your PR of cases where you used this? This would make it easier to understand for people and those can be use for updating the readme. Do you also have time to look at the comments? Last but not least, can you also update the docs?
| @@ -21,11 +21,13 @@ export interface AfterScreenshotOptions { | |||
| // The file name options object | |||
| fileName: ScreenshotFileNameOptions; | |||
| // Elements that need to be hidden (visibility: hidden) before saving a screenshot | |||
| hideElements: (HTMLElement | HTMLElement[])[]; | |||
| hideElements: HTMLElement[]; | |||
There was a problem hiding this comment.
Why did you change the interface here? hideElements and removeElements will always be an array that hold or single elements, or a combination of single elements and an array of elements (like [$('something'), $$('something-else')])
| @@ -32,7 +32,8 @@ | |||
| "dependencies": { | |||
| "canvas": "^2.6.0", | |||
| "chalk": "^2.4.2", | |||
| "fs-extra": "^7.0.1" | |||
| "fs-extra": "^7.0.1", | |||
| "gm": "^1.23.1" | |||
There was a problem hiding this comment.
I try to prevent using non standard environment modules like imagemagick and graphicsmagick. Not every user/customer has this standard installed in their CI pipeline which makes this break in pipelines.
ResembleJS also provides a ignoreColors option, doesn't that work?
There was a problem hiding this comment.
I will have to take a look and I will look at commments soon!
There was a problem hiding this comment.
OK so ignoreColors does not work for me, that basically will compare at grayscale.
The usage of this solves is reading "painted on" captions from a video frame where the video frame may have slight differences.
Our app is a testbed for our video player, in that player, there are 608 captions painted on, over video. In order to validate them, we need to extract captions. However, since there are small changes to the background image even ignoring colors doesn't help. What this does is take any color and floor it to black (not grays), leaving a pure black image with white text to compare.
There was a problem hiding this comment.
Also, these libraries are only looked for and used if this option is enabled... I understand non-standard libraries but if you use this option you will need to install the required components.
mikesalvia
force-pushed
the
master
branch
3 times, most recently
from
7bb2b2d
to
5935ddd
Compare
|
|
mikesalvia
force-pushed
the
master
branch
2 times, most recently
from
4c74825
to
a805af9
Compare
|
@wswebcreation Wanted to see your thoughts on this feature. I have realized it will rely on GraphicsMagick if installed but fails gracefully if it is not installed. |
|
Hi @mikesalvia I've been thinking about this feature and I do believe this is a really great feature. Still I wonder if this is needs to be done with other libs than ResembleJS. Secondly this is a really unique case (IMHO, sorry) for which we add some extra dependencies (even though you made it fail gracefully if it is not installed). By adding GraphicsMagick we open a complete new door in doing the comparison, which also increases the change in getting more questions from people on how to use this, if it supports more options and so on. My proposal would be the following:
What do you think |
|
Going to close it due to inactivity |
This PR allows for users to switch color in the collected image into black. This was very helpful in verifying "painted on" captions in ExoPlayer and AVPlayer for Android and iOS respectively.