Update dependencies to support Laravel v9 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karl-d
requested changes
Jul 14, 2022
| @@ -1,5 +1,4 @@ | |||
| export enum Enum { | |||
|
|
|||
There was a problem hiding this comment.
Just this feels a little odd here with the export being removed.
Are we also just able to add a test to the different type as well?
There was a problem hiding this comment.
Yea it's a strange change, adding the type is now handled by the spatie/typescript-transformer library rather than this transformer.
I'll look at adding separate tests for the type and enum conversion
There was a problem hiding this comment.
Ok, if that is the case we can just merge to get thing progressing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated to support Laravel V9 and the latest version of
spatie/typescript-transformerspatie/typescript-transformer 2.1.3 introduced a breaking change to this package,
https://github.com/spatie/typescript-transformer/releases/tag/2.1.3