Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop factor of 0.83 in contribution function #236

Closed
wtbarnes opened this issue Apr 9, 2023 · 3 comments
Closed

Drop factor of 0.83 in contribution function #236

wtbarnes opened this issue Apr 9, 2023 · 3 comments
Labels
discussion Issues that require some extended deliberation effort-low Ion Anything related to the Ion object

Comments

@wtbarnes
Copy link
Owner

wtbarnes commented Apr 9, 2023

The contribution function method currently includes a factor of $n_H/n_e\approx0.83$. This should be dropped as users may want to make different assumptions when it comes to what this ratio is. This means that the resulting EM is $n_Hn_e$ rather than $n_e^2$.

@wtbarnes
Copy link
Owner Author

The AIA response function example will need to be adjusted appropriately if this change as made as well as the documentation for the contribution function method to make sure that it is clear to users that this factor is not included.

@wtbarnes wtbarnes added effort-low Ion Anything related to the Ion object Good First Issue The best issues for new people to tackle! labels Jan 12, 2024
@wtbarnes
Copy link
Owner Author

Alternatively, we could use proton_to_electron_ratio. The most important thing is that we are consistent anywhere this factor comes up. The three options then are:

  1. Keep 0.83
  2. Use the proton-electron ratio
  3. Drop this factor entirely such that $EM\sim n_Hn_e$ rather than $n_e^2$

@wtbarnes wtbarnes added discussion Issues that require some extended deliberation and removed Good First Issue The best issues for new people to tackle! labels Mar 14, 2024
@wtbarnes
Copy link
Owner Author

Closed by #273. The decision is to drop the factor entirely (option 3) in the contribution function, use an assumed ratio to compute $n_H$ for the emissivity, and then interpret the EM in intensity as $n_en_H$.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Issues that require some extended deliberation effort-low Ion Anything related to the Ion object
Projects
None yet
Development

No branches or pull requests

1 participant