Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDL Contribution function comparisons need to be multiplied by 0.83 #285

Closed
wtbarnes opened this issue May 16, 2024 · 0 comments · Fixed by #288
Closed

IDL Contribution function comparisons need to be multiplied by 0.83 #285

wtbarnes opened this issue May 16, 2024 · 0 comments · Fixed by #288
Labels
docs effort-low Good First Issue The best issues for new people to tackle!
Milestone

Comments

@wtbarnes
Copy link
Owner

The documentation build automatically computes some comparisons with some contribution functions computed by IDL: https://fiasco.readthedocs.io/en/latest/generated/gallery/idl_comparisons/goft_comparison.html#. However, the diffs now appear to be signficantly larger than before. I am pretty sure this is due to the exclusion of the factor of $n_H/n_e\approx0.83$ in the contribution function as of #236.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs effort-low Good First Issue The best issues for new people to tackle!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant