Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to documentation theme and package infrastructure fixes #286

Merged
merged 4 commits into from
May 22, 2024

Conversation

nabobalis
Copy link
Contributor

@nabobalis nabobalis commented May 21, 2024

This PR provides a number of fixes to the documentation, particularly in the appearance of the Pydata theme. There are also a number of fixes to how the formatting tools are applied as well as other infrastructure bits.

eduard-khil_trans_NvBQzQNjv4BqVKOd1ILXaurCHi1o16wQuQanpLbznLmtmLfsIXrFY2I

fiasco/io/factory.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 92.38%. Comparing base (9ab2c61) to head (e07916d).

Files Patch % Lines
fiasco/collections.py 50.00% 2 Missing ⚠️
fiasco/util/util.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #286      +/-   ##
==========================================
- Coverage   92.92%   92.38%   -0.54%     
==========================================
  Files          38       38              
  Lines        2896     2904       +8     
==========================================
- Hits         2691     2683       -8     
- Misses        205      221      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nabobalis nabobalis force-pushed the docs branch 4 times, most recently from 750b86b to 4311424 Compare May 21, 2024 21:21
fiasco/io/__init__.py Outdated Show resolved Hide resolved
fiasco/io/__init__.py Outdated Show resolved Hide resolved
fiasco/io/factory.py Outdated Show resolved Hide resolved
Co-authored-by: Will Barnes <will.t.barnes@gmail.com>
fiasco/util/exceptions.py Outdated Show resolved Hide resolved
Co-authored-by: Will Barnes <will.t.barnes@gmail.com>
@wtbarnes wtbarnes changed the title trololol Fixes to documentation theme and package infrastructure fixes May 22, 2024
@wtbarnes wtbarnes merged commit 7dddd7e into wtbarnes:main May 22, 2024
15 of 17 checks passed
@nabobalis nabobalis deleted the docs branch May 23, 2024 21:59
@wtbarnes wtbarnes mentioned this pull request Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants