Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support looking up Japanese-English #13

Closed
wtetsu opened this issue Nov 1, 2018 · 4 comments
Closed

Support looking up Japanese-English #13

wtetsu opened this issue Nov 1, 2018 · 4 comments
Assignees
Milestone

Comments

@wtetsu
Copy link
Owner

wtetsu commented Nov 1, 2018

Like this

ja

@wtetsu wtetsu self-assigned this Nov 1, 2018
@wtetsu
Copy link
Owner Author

wtetsu commented Dec 9, 2018

Beta version is now available.
https://github.com/wtetsu/mouse-dictionary/wiki/Getting-started

@RobertB4
Copy link

@wtetsu package.json includes the following script:
"build-chrome-ja": "webpack --config webpack.config.chrome.ja.js"
but there is no file called webpack.config.chrome.ja.js . Do you have any plans to add it to the repository?

@wtetsu
Copy link
Owner Author

wtetsu commented Dec 23, 2018

@RobertB4
Thank you for pointing it out.

The scripts "*-ja" are no longer needed, so I'll remove them.

My first idea was creating another build in order to support the Japanese-English feature. "*-ja" are scripts for the build. My current idea is make one build support both English-Japanese and Japanese-English. I'm developping it in another branch. The beta version was built from this branch.

https://github.com/wtetsu/mouse-dictionary/tree/feature/support_ja-en

Note: In reallity, this extension can lookup English-* and Japense-*.(e.g. English-Spanish, Japanese-Chinese, ...)

wtetsu added a commit that referenced this issue Dec 23, 2018
@wtetsu wtetsu added this to the v1.2.0 milestone Feb 26, 2019
@wtetsu
Copy link
Owner Author

wtetsu commented Mar 17, 2019

v1.2.0

@wtetsu wtetsu closed this as completed Mar 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants