Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.0.0 rewrite #7

Merged
merged 14 commits into from
Apr 19, 2017
Merged

v2.0.0 rewrite #7

merged 14 commits into from
Apr 19, 2017

Conversation

wtfaremyinitials
Copy link
Owner

@wtfaremyinitials wtfaremyinitials commented Apr 11, 2017

Features

  • Reintroduce receive functionality
  • Promise based API
  • Split up contact lookup and message sending
  • Better documentation
  • Example code

Bugs

  • A race condition can cause the same message to be emitted twice
  • Improve error handling

Notable changes
 - Reintroduce receive functionality (more robust than before)
 - Split `send(name, message)` into `send(handle, message)` and
   `handleForName(name)`
 - Promise based API
@wtfaremyinitials wtfaremyinitials mentioned this pull request Apr 11, 2017
Pretty sure it was caused by the `date` column being updated
when a message is read/delivered. Keeping track of which message
guids have been reported should fix the problem.
@wtfaremyinitials wtfaremyinitials merged commit 0d46cfc into master Apr 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant