Explicitly check if db_session is None in converter #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 23, 2019 17:35
This allows the use of a Werkzeug LocalProxy for handling sessions tied to requests, for example. An unbound LocalProxy is falsey, and the session LocalProxy is unbound during application start up, but the session will exist by the time a form is actually built.
mx-moth
force-pushed
the
db-session-is-none
branch
from
96e9adc
to
a850998
Compare
mx-moth
force-pushed
the
db-session-is-none
branch
from
a850998
to
5a18ee7
Compare
|
The Travis build is fixed now. It is using very out-of-date versions of packages! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the use of a Werkzeug LocalProxy for handling sessions tied to requests, for example. An unbound LocalProxy is falsey, and the session LocalProxy is unbound during application start up, but the session will exist by the time a form is actually built.
I also fixed some errors in the tests while I was at it.