remove 2 decimal place default for Numeric/Float #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, Could this be accepted and merged & released ? it's quite blocking ... :s |
mx-moth
pushed a commit
to mx-moth/wtforms-sqlalchemy
that referenced
this pull request
Jan 21, 2020
…nflict Resolve wtforms#2 WTForms 1.0.15 Python 3.8 conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's common for users to use Float for GPS coordinates, and having a default of 2 decimal places isn't desirable.
This pull request changes the default to unlimited decimal places. And, instead relies on SQLAlchemy or the database to set limits on the displayed number of decimal places.
More details available here: flask-admin/flask-admin#1155