Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

football module not working #1183

Closed
allotmentandy opened this issue Feb 12, 2022 · 3 comments · Fixed by #1222
Closed

football module not working #1183

allotmentandy opened this issue Feb 12, 2022 · 3 comments · Fixed by #1222
Labels
🐛 bug "Houston, we've had a problem."

Comments

@allotmentandy
Copy link

What's broken?

hi, i have been setting up wtfutil using a lot of modules, but the football one doesnt work

is it just a case of changing the url to https?

https://api.football-data.org/v2

instead of

http://api.football-data.org/v2

in

wtf/modules/football/client.go

Line 9 in b8eae57

footballAPIUrl = "http://api.football-data.org/v2"

@senorprogrammer senorprogrammer added the 🐛 bug "Houston, we've had a problem." label Feb 15, 2022
@senorprogrammer
Copy link
Collaborator

Yep, a quick look suggests it is that simple!

despreston added a commit to despreston/wtf that referenced this issue Apr 19, 2022
@despreston
fix(football): http -> https
59f5433 
Fixes wtfutil#1183
despreston added a commit to despreston/wtf that referenced this issue Apr 19, 2022
@despreston
fix(football): http -> https
e895c3b 
Fixes wtfutil#1183
@despreston despreston mentioned this issue Apr 19, 2022
Merged
@stale
Copy link

stale bot commented May 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label May 16, 2022
@senorprogrammer
Copy link
Collaborator

Seems fixable.

senorprogrammer pushed a commit that referenced this issue May 31, 2022
@despreston
fix(football): http -> https (#1222)
86d5b0e 
Fixes #1183
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug "Houston, we've had a problem."
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(football): http -> https despreston/wtf
2 participants
@senorprogrammer @allotmentandy