Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented UptimeRobot widget #983

Closed
wants to merge 4 commits into from

Conversation

franga2000
Copy link
Contributor

@franga2000 franga2000 commented Oct 3, 2020

Hi! This is the PR corresponding to my proposal in #979.

There are still a couple of things I'd like to implement, but I'm submitting the PR now to track my progress and see what CI has to say about my code.

Here's what it looks like now with my config:

uptimerobot:
      apiKey: --redacted--
      enabled: true
      uptimePeriods: 7-30

image

TODO

  • Make symbols configurable
  • Make colors configurable (maybe just a general prefix?)
  • Improve the default formatting of uptime ratios
  • Add option to sort monitors by status (pull offline ones to the top)

This is the first working version of the UptimeRobot module, as discussed in wtfutil#979
@senorprogrammer
Copy link
Collaborator

Looks good so far.

@senorprogrammer
Copy link
Collaborator

Just checking in: do you want this merged, or are you waiting on doing the other todo's?

@franga2000
Copy link
Contributor Author

Sorry for the silence, I got a bunch of work thrown at me out of nowhere. It's probably best you merge it and if anyone asks for the customization options or I get some spare time in the future, I can send another PR.

@senorprogrammer
Copy link
Collaborator

This branch has been accepted and merged. Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants