-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash on Windows due to improper backslash handling in autojump_match.py #436
Comments
Hey thanks for the detailed bug report! Unfortunately I don't have access to a Windows machine. Can you update these Windows tests such that they reproduce the error you have? That way we can prevent future regression bugs. |
Just trying out autojump on Win10 and hit this. The proposed patch seems to work for me. |
@wting If the tests are not actually executed on Windows, won't the match_consecutive tests pick up the wrong |
You can mock it out for tests like so: In [1]: import os, mock
In [2]: os.sep
Out[2]: '/'
In [3]: with mock.patch.object(os, 'sep', '\\'):
...: print(os.sep)
...:
\ |
I had the same problem and the suggested fix solved the problem. I guess that an alternative solution would be to run the tests on a windows CI platform such as appveyor. |
Fix for windows issue wting#436
win 10 64 , the same issue. change autojump_match.py worked. thank you. |
Window 10 professional, I met this issue today....and the suggested patch works like a charm! Many thanks. I just wonder why the patch is not merged into the master while four years have been passed? |
Executing any normal autojump command in Windows leads to this:
The highlighted change here: 7c7865e#diff-4b97c2fd2ae952c567c1646bc80e5d43L78
lead to the dysfunction in Windows systems.
The proposed solution is basically changing the lines 78-80 in autojump_match.py to:
(Conditionally setting the separator value used in the regex construction)
The text was updated successfully, but these errors were encountered: