You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
in pysis.env is all what controls where to find ISISROOT.
I have found this very fickle in trying to make things work across several conda environments (which is now the default install for ISIS3), so I propose to add functionality to pysis.env.py to get the paths from a config file in the users' home.
Currently, this file on my side simply looks like this:
and I'm using the toml format (https://github.com/toml-lang/toml).
I'm thinking about a few approaches how this fluently could be combined with an existing os.enviroment variable, but let's discuss these details in my PR I gonna start later this week after my current meeting is over (where, of course, I needed pysis to work and it didn't ;) ).
We could also have this config file to be created after the current ISIS3 install, it's simple enough. But much more stable against environment variable manipulations caused by switching conda envs (admittedly, that's the whole idea of conda, obviously).
The text was updated successfully, but these errors were encountered:
Should be simple enough to prefer a config over an env var (config doesn't exist, back up to use an env var). But what do you mean by "We could also have this config file to be created after the current ISIS3 install"? As in make ISIS generate a pysis config file? That is how I am understanding it which I don't think would be ideal.
The line:
in
pysis.env
is all what controls where to find ISISROOT.I have found this very fickle in trying to make things work across several conda environments (which is now the default install for
ISIS3
), so I propose to add functionality topysis.env.py
to get the paths from a config file in the users' home.Currently, this file on my side simply looks like this:
and I'm using the
toml
format (https://github.com/toml-lang/toml).I'm thinking about a few approaches how this fluently could be combined with an existing os.enviroment variable, but let's discuss these details in my PR I gonna start later this week after my current meeting is over (where, of course, I needed pysis to work and it didn't ;) ).
We could also have this config file to be created after the current
ISIS3
install, it's simple enough. But much more stable against environment variable manipulations caused by switching conda envs (admittedly, that's the whole idea of conda, obviously).The text was updated successfully, but these errors were encountered: