Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code review request #1

Open
GoogleCodeExporter opened this issue Mar 21, 2015 · 0 comments
Open

Code review request #1

GoogleCodeExporter opened this issue Mar 21, 2015 · 0 comments

Comments

@GoogleCodeExporter
Copy link

Purpose of code changes on this branch:
Adding support to remove navigation (bottom) bar from Safari.

If you change the example zflow.html headers like so:

<!DOCTYPE html PUBLIC "-//WAPFORUM//DTD XHTML Mobile 1.1//EN" 
"http://www.openmobilealliance.org/tech/DTD/xhtml-mobile11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
    <title>CSS VFX Example - 3D Coverflow | Flickr</title>
    <!-- the apple touch icon will let us specify a 57x57 icon when the user adds the bookmark 
to their home screen -->
    <link rel="apple-touch-icon" href="html/swap.png"/>
    <meta name="viewport" content="width=device-width, minimum-scale=1.0, maximum-
scale=1.0, user-scalable=0"/>
    <meta http-equiv="Content-Type" content="text/html; charset=utf-8"/>
    <!-- these two apple meta tags will turn the bottom nav bar off when the user adds the 
website to their home screen -->
    <meta name="apple-mobile-web-app-capable" content="yes" />
    <meta name="apple-mobile-web-app-status-bar-style" content="black" /> 

When reviewing my code changes, please focus on:
 the apple-movile-web-app-* meta tags and the DOCTYPE and xmlns attribute on html seem to 
be necessary.

The apple-touch-icon is extraneous, but fun.

After the review, if you like it, check it in. :)

Alternately, I can provide an example that does not use flickr and uses a 
static image set instead, 
which might be more prolific.
Thanks.






Original issue reported on code.google.com by jelw...@gmail.com on 6 Jan 2009 at 12:54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant