Skip to content

Commit

Permalink
Fixed the SeqQC pulldown metrics display bug (#858)
Browse files Browse the repository at this point in the history
This was introduced while updating the SeqQC summary
display for pulldown_metrics incomplete results. The
bug manifestation is a display appearance of an
unexpected raw mean depth value just before the coverage
value. Also, display proper metrics for zero coverage
  • Loading branch information
mgcam committed Apr 4, 2024
1 parent cb2d041 commit 1d116e2
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
5 changes: 5 additions & 0 deletions Changes
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
LIST OF CHANGES FOR NPG-QC PACKAGE

- Fixed the bug that was introduced while updating the SeqQC summary display
for pulldown_metrics incomplete results. The bug manifestation is a display
appearence of an unexpected raw mean depth value just before the coverage
value. All values that should be displayed were unaffected by the bug.

release 72.0.1
- Ensured that retrieving values from a partially defined pulldown_metrics
result does not trigger an error. Added a test to demonstrate that such
Expand Down
4 changes: 2 additions & 2 deletions npg_qc_viewer/root/src/ui_lanes/lane.tt2
Original file line number Diff line number Diff line change
Expand Up @@ -425,7 +425,7 @@ END
[% href='#pdmc_' _ result.id_run _ ':' _ result.position _ ':' _ result.tag_index %]

[%-
mcoverage;
mcoverage = -1;
IF result.unique_bases_aligned_num.defined && result.unique_bases_aligned_num != 0;
mcoverage = result.mean_target_coverage / (result.unique_bases_aligned_num / 1000000000);
END;
Expand All @@ -439,7 +439,7 @@ END
END;
coverage = result.target_bases_coverage_percent.20 ? result.target_bases_coverage_percent.20 : 0;
-%]
[% IF mcoverage.defined %]
[% IF mcoverage >= 0 %]
[% IF result.interval_files_identical.defined && result.interval_files_identical == 1 %]
<span class="pdmc_na" title="Bait and target intervals identical"><a href="[% href %]">NA&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;NA<br/></a></span>
<span class="dark_blue" title="On-bait bases %age"><a href="[% href %]">[% FILTER format('%2.2f');on_bait;END %]&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;</a></span>
Expand Down

0 comments on commit 1d116e2

Please sign in to comment.