Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed lib.logger and reflected in annotation and analyzer. #83

Merged
merged 5 commits into from
May 21, 2024

Conversation

musashi1729
Copy link
Contributor

lib.loggerに親ロガーを用意する方法でloggerを必須引数から外すようにしました。
とりあえずlib.annotationとtools.analyzerにだけ実装してます。

Copy link
Collaborator

@delta-river delta-river left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修正ありがとうございます!
動作確認はしていないですが,見たところ特に問題なさそうでした.

@delta-river
Copy link
Collaborator

ちなみに,./server/__main__.py./server/miogatto.py にも logger が出てくるのですが,そちらも対応が必要かもしれません.

ぱっと,grep を掛けたところ,↓のような感じなので,少なくとも ./server/__main__.pyはMiAnno, McDict に関して修正が必要そうです.

./server/__main__.py:    mi_anno = MiAnno(anno_json, app.logger)
./server/__main__.py:    mcdict = McDict(mcdict_json, app.logger)
./server/__main__.py:    server = MioGattoServer(paper_id, tree, mi_anno, mcdict, app.logger)
./server/miogatto.py:    def __init__(self, paper_id: str, tree, mi_anno: MiAnno, mcdict: McDict, logger: Logger):
./server/miogatto.py:        self.logger = logger

@wtsnjp wtsnjp merged commit 5949776 into wtsnjp:main May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants